Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Optuna should ignore additional results after trial termination #23495

Merged
merged 3 commits into from
Mar 28, 2022
Merged

[tune] Optuna should ignore additional results after trial termination #23495

merged 3 commits into from
Mar 28, 2022

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

In rare cases (#19274) (and possibly old versions of Ray), buffered results can lead to calling on_trial_complete multiple times with the same trial ID. In these cases, Optuna should gracefully handle this case and discard the results.

Related issue number

Closes #19274

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Yard1
Yard1 approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krfricke krfricke mentioned this pull request Mar 25, 2022
Closed
2 tasks
@krfricke krfricke merged commit 6241452 into ray-project:master Mar 28, 2022
@krfricke krfricke deleted the tune/optuna-add-result branch March 28, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwjiang2010 xwjiang2010 xwjiang2010 approved these changes

@Yard1 Yard1 Yard1 approved these changes

Assignees

@Yard1 Yard1

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Tune crashes with "RuntimeError: Trial#8161 has already finished and can not be updated" in ray 1.7.0
3 participants
@krfricke @Yard1 @xwjiang2010